From 18569ab55674ae7287afbfc2128932c140367987 Mon Sep 17 00:00:00 2001 From: bd_ Date: Fri, 24 Jan 2025 18:29:00 -0800 Subject: [PATCH] fix: deletedShape animation curves are retained in final avatar animations This results in downstream tools such as AAO improperly treating these objects as animated. --- .../AnimationGeneration/ReactiveObjectPass.cs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Editor/ReactiveObjects/AnimationGeneration/ReactiveObjectPass.cs b/Editor/ReactiveObjects/AnimationGeneration/ReactiveObjectPass.cs index 2d73a816..30869878 100644 --- a/Editor/ReactiveObjects/AnimationGeneration/ReactiveObjectPass.cs +++ b/Editor/ReactiveObjects/AnimationGeneration/ReactiveObjectPass.cs @@ -286,6 +286,15 @@ namespace nadena.dev.modular_avatar.core.editor }); } } + + // Remove all deletedShape. props to avoid creating animator noise that'll confuse tools like AAO + foreach (var key in shapes.Keys.ToList()) + { + if (key.PropertyName.StartsWith(ReactiveObjectAnalyzer.DeletedShapePrefix)) + { + shapes.Remove(key); + } + } } #endregion