AnimeFunsion/modular-avatar
1
0
Fork 0
mirror of https://github.com/bdunderscore/modular-avatar.git synced 2024-12-29 18:55:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve parameter inspector perf when using lots of parameters

Browse Source 
This doesn't fully close #217, but it's an improvement. Fully fixing it will require reworking the UI fully (or getting unity to fix their terrible code :/)
This commit is contained in:
bd_ 2023-02-22 23:29:45 +09:00 committed by GitHub
parent d385eb8800
commit 887f7d0dff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
Packages/nadena.dev.modular-avatar/Editor/Inspector/AvatarParametersEditor.cs
View File

@ -175,25 +175,40 @@ namespace nadena.dev.modular_avatar.core.editor
_needsRebuild = true;
}
private float ElementHeight(int index)
// https://github.com/bdunderscore/modular-avatar/issues/217
private float[] ElementHeightCache = null;
private float[] BuildHeightCache()
{
float baseHeight = _devMode ? elemHeight * 2 : elemHeight;
float[] cache = new float[_selectedIndices.Count];
var param = GetParamByIndex(_selectedIndices[index]);
var syncMode = param.FindPropertyRelative(nameof(ParameterConfig.syncType));
if (syncMode.enumValueIndex != (int) ParameterSyncType.NotSynced)
for (int i = 0; i < _selectedIndices.Count; i++)
{
baseHeight += elemHeight;
float baseHeight = _devMode ? elemHeight * 2 : elemHeight;
var param = GetParamByIndex(_selectedIndices[i]);
var syncMode = param.FindPropertyRelative(nameof(ParameterConfig.syncType));
if (syncMode.enumValueIndex != (int) ParameterSyncType.NotSynced)
{
baseHeight += elemHeight;
}
if (_selectedIndices[i] == -1)
{
cache[i] = elemHeight + baseHeight;
}
else
{
cache[i] = baseHeight;
}
}
if (_selectedIndices[index] == -1)
{
return elemHeight + baseHeight;
}
else
{
return baseHeight;
}
return cache;
}
private float ElementHeight(int reqIndex)
{
return ElementHeightCache[reqIndex];
}
private void DrawAutodetectHeader(ref Rect rect)
@ -412,6 +427,8 @@ namespace nadena.dev.modular_avatar.core.editor
protected override void OnInnerInspectorGUI()
{
ElementHeightCache = BuildHeightCache();
EditorGUI.BeginChangeCheck();
_devMode = EditorGUILayout.Toggle(G("params.devmode"), _devMode);
if (EditorGUI.EndChangeCheck() || _reorderableList == null || _needsRebuild) SetupList();