From 63c02314ccad8aaed853cf5b17e79c4a32d14657 Mon Sep 17 00:00:00 2001 From: catboxanon <122327233+catboxanon@users.noreply.github.com> Date: Thu, 18 May 2023 13:06:13 -0400 Subject: [PATCH 1/2] .change -> .release for hires input Improves overall UI responsiveness. --- modules/ui.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/modules/ui.py b/modules/ui.py index 3be5257ab..025967575 100644 --- a/modules/ui.py +++ b/modules/ui.py @@ -513,15 +513,14 @@ def create_ui(): with FormGroup(elem_id="txt2img_script_container"): custom_inputs = modules.scripts.scripts_txt2img.setup_ui() - hr_resolution_preview_inputs = [enable_hr, width, height, hr_scale, hr_resize_x, hr_resize_y] - for input in hr_resolution_preview_inputs: - input.change( + def update_resolution_hires_input(inp, evt): + getattr(inp, evt)( fn=calc_resolution_hires, inputs=hr_resolution_preview_inputs, outputs=[hr_final_resolution], show_progress=False, ) - input.change( + getattr(inp, evt)( None, _js="onCalcResolutionHires", inputs=hr_resolution_preview_inputs, @@ -529,6 +528,11 @@ def create_ui(): show_progress=False, ) + hr_resolution_preview_inputs = [enable_hr, width, height, hr_scale, hr_resize_x, hr_resize_y] + update_resolution_hires_input(enable_hr, 'change') + for input in hr_resolution_preview_inputs[1:]: + update_resolution_hires_input(input, 'release') + txt2img_gallery, generation_info, html_info, html_log = create_output_panel("txt2img", opts.outdir_txt2img_samples) connect_reuse_seed(seed, reuse_seed, generation_info, dummy_component, is_subseed=False) From 57275da90379ae78232944e7cf181a55ed7c1b57 Mon Sep 17 00:00:00 2001 From: catboxanon <122327233+catboxanon@users.noreply.github.com> Date: Thu, 18 May 2023 13:25:32 -0400 Subject: [PATCH 2/2] Reorder variable assignment --- modules/ui.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/ui.py b/modules/ui.py index 025967575..4d1b90782 100644 --- a/modules/ui.py +++ b/modules/ui.py @@ -513,6 +513,8 @@ def create_ui(): with FormGroup(elem_id="txt2img_script_container"): custom_inputs = modules.scripts.scripts_txt2img.setup_ui() + hr_resolution_preview_inputs = [enable_hr, width, height, hr_scale, hr_resize_x, hr_resize_y] + def update_resolution_hires_input(inp, evt): getattr(inp, evt)( fn=calc_resolution_hires, @@ -528,7 +530,6 @@ def create_ui(): show_progress=False, ) - hr_resolution_preview_inputs = [enable_hr, width, height, hr_scale, hr_resize_x, hr_resize_y] update_resolution_hires_input(enable_hr, 'change') for input in hr_resolution_preview_inputs[1:]: update_resolution_hires_input(input, 'release')