Update launch_utils.py

Updated the cloning logic to first clone into a temporary directory and move it to the final destination only if the operation succeeds.
This commit is contained in:
Daniel 2025-01-13 02:10:24 +14:00 committed by GitHub
parent 021154d8b1
commit ccc3d8edee
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -167,7 +167,8 @@ def run_git(dir, name, command, desc=None, errdesc=None, custom_env=None, live:
def git_clone(url, dir, name, commithash=None): def git_clone(url, dir, name, commithash=None):
# TODO clone into temporary dir and move if successful # Clone into a temporary directory
temp_dir = dir + "_temp"
if os.path.exists(dir): if os.path.exists(dir):
if commithash is None: if commithash is None:
@ -187,9 +188,10 @@ def git_clone(url, dir, name, commithash=None):
return return
try: try:
run(f'"{git}" clone --config core.filemode=false "{url}" "{dir}"', f"Cloning {name} into {dir}...", f"Couldn't clone {name}", live=True) run(f'"{git}" clone --config core.filemode=false "{url}" "{temp_dir}"', f"Cloning {name} into {temp_dir}...", f"Couldn't clone {name}", live=True)
shutil.move(temp_dir, dir) # Move temp directory to final directory
except RuntimeError: except RuntimeError:
shutil.rmtree(dir, ignore_errors=True) shutil.rmtree(temp_dir, ignore_errors=True)
raise raise
if commithash is not None: if commithash is not None: