AnimeFunsion/modular-avatar
1
0
Fork 0
mirror of https://github.com/bdunderscore/modular-avatar.git synced 2024-12-29 18:55:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Use VRCParentConstraint instead of constraint hack for world fixed objects when available (#1326)" (#1363)

Browse Source 
This reverts commit a984cf8673. The prior
behavior was to lock world fixed objects at their offset from the
origin; however with this change we ended up locking them at a location
relative to the avatar spawn location, breaking some gimmicks.

I tried experimenting a bit with VRCConstraint to try to replicate this
behavior, but it seems a bit non-trivial, so we'll revert this as a
hotfix for now.
This commit is contained in:
bd_ 2024-11-19 19:04:33 -08:00 committed by GitHub
parent 9f4a7a6304
commit 46f5296528
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
Editor/WorldFixedObjectProcessor.cs
View File

@ -86,15 +86,6 @@ namespace nadena.dev.modular_avatar.core.editor
obj.transform.localRotation = Quaternion.identity; obj.transform.localRotation = Quaternion.identity;
obj.transform.localScale = Vector3.one; obj.transform.localScale = Vector3.one;
if (!TryCreateVRCConstraint(avatarRoot, obj)) CreateConstraint(obj, fixedGameObject);
_proxy = obj.transform;
return obj.transform;
}
private void CreateConstraint(GameObject obj, GameObject fixedGameObject)
{
var constraint = obj.AddComponent<ParentConstraint>(); var constraint = obj.AddComponent<ParentConstraint>();
constraint.AddSource(new ConstraintSource() constraint.AddSource(new ConstraintSource()
{ {
@ -105,31 +96,10 @@ namespace nadena.dev.modular_avatar.core.editor
constraint.locked = true; constraint.locked = true;
constraint.rotationOffsets = new[] {Vector3.zero}; constraint.rotationOffsets = new[] {Vector3.zero};
constraint.translationOffsets = new[] {Vector3.zero}; constraint.translationOffsets = new[] {Vector3.zero};
}
#if MA_VRCSDK3_AVATARS_3_7_0_OR_NEWER _proxy = obj.transform;
private bool TryCreateVRCConstraint(Transform avatarRoot, GameObject obj)
{
var isVrcAvatar = avatarRoot.TryGetComponent(out VRC.SDKBase.VRC_AvatarDescriptor _);
if (!isVrcAvatar) return false; return obj.transform;
}
var constraint = obj.AddComponent(
System.Type.GetType("VRC.SDK3.Dynamics.Constraint.Components.VRCParentConstraint, VRC.SDK3.Dynamics.Constraint")
) as VRC.Dynamics.ManagedTypes.VRCParentConstraintBase;
constraint.IsActive = true;
constraint.Locked = true;
constraint.AffectsPositionX = true;
constraint.AffectsPositionY = true;
constraint.AffectsPositionZ = true;
constraint.AffectsRotationX = true;
constraint.AffectsRotationY = true;
constraint.AffectsRotationZ = true;
constraint.FreezeToWorld = true;
return true;
}
#else
private bool TryCreateVRCConstraint(Transform avatarRoot, GameObject obj) => false;
#endif
} }
} }

23
UnitTests~/WorldFixedObjectTest/WorldFixedObjectTest.cs
View File

@ -3,7 +3,6 @@ using nadena.dev.modular_avatar.animation;
using nadena.dev.modular_avatar.core; using nadena.dev.modular_avatar.core;
using nadena.dev.modular_avatar.core.editor; using nadena.dev.modular_avatar.core.editor;
using NUnit.Framework; using NUnit.Framework;
using UnityEngine;
using UnityEngine.Animations; using UnityEngine.Animations;
public class WorldFixedObjectTest : TestBase public class WorldFixedObjectTest : TestBase
@ -26,16 +25,7 @@ public class WorldFixedObjectTest : TestBase
// fixed root is created // fixed root is created
Assert.That(fixedRoot, Is.Not.Null); Assert.That(fixedRoot, Is.Not.Null);
bool isVrcAvatar = false; Assert.That(fixedRoot.GetComponent<ParentConstraint>(), Is.Not.Null);
System.Type vrcParentConstraintType = null;
#if MA_VRCSDK3_AVATARS
isVrcAvatar = avatar.TryGetComponent(out VRC.SDKBase.VRC_AvatarDescriptor _);
vrcParentConstraintType = System.Type.GetType("VRC.SDK3.Dynamics.Constraint.Components.VRCParentConstraint, VRC.SDK3.Dynamics.Constraint");
#endif
Component constraint = isVrcAvatar && vrcParentConstraintType != null ?
fixedRoot.GetComponent(vrcParentConstraintType) :
fixedRoot.GetComponent<ParentConstraint>();
Assert.That(constraint, Is.Not.Null);
// objects are moved to fixed root // objects are moved to fixed root
Assert.That(movedFixedObject, Is.Not.Null); Assert.That(movedFixedObject, Is.Not.Null);
@ -62,16 +52,7 @@ public class WorldFixedObjectTest : TestBase
// fixed root is created // fixed root is created
Assert.That(fixedRoot, Is.Not.Null); Assert.That(fixedRoot, Is.Not.Null);
bool isVrcAvatar = false; Assert.That(fixedRoot.GetComponent<ParentConstraint>(), Is.Not.Null);
System.Type vrcParentConstraintType = null;
#if MA_VRCSDK3_AVATARS
isVrcAvatar = avatar.TryGetComponent(out VRC.SDKBase.VRC_AvatarDescriptor _);
vrcParentConstraintType = System.Type.GetType("VRC.SDK3.Dynamics.Constraint.Components.VRCParentConstraint, VRC.SDK3.Dynamics.Constraint");
#endif
Component constraint = isVrcAvatar && vrcParentConstraintType != null ?
fixedRoot.GetComponent(vrcParentConstraintType) :
fixedRoot.GetComponent<ParentConstraint>();
Assert.That(constraint, Is.Not.Null);
// objects are moved to fixed root // objects are moved to fixed root
Assert.That(movedFixedObject, Is.Not.Null); Assert.That(movedFixedObject, Is.Not.Null);